search

WarnerMedia / gimme-aws-creds

Apache License 2.0
21 stars 7 forks source link

Dependencies issue #11

Open andrewwood-wbg opened 3 years ago

andrewwood-wbg commented 3 years ago

Default install of Python 3.9.2 gives you ctap-keyring-device 1.0.6 which satisfies requirements.txt checks, however that requires fido2>=0.9.1 which fails the requirements.txt check.

Release notes for fido https://github.com/Yubico/python-fido2/releases suggest nothing that would break so maybe we can just update the version in the requirements.txt?

delilahlah commented 3 years ago

I'm seeing the same thing with with a fresh install.

This fixed it for me:

diff --git a/requirements.txt b/requirements.txt
index 9ac6d46..cc6731b 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -4,6 +4,6 @@ beautifulsoup4>=4.6.0,<5.0.0
 configparser>=3.5.0,<4.0.0
 keyring>=21.4.0
 requests>=2.13.0,<3.0.0
-fido2>=0.8.1,<=0.9.0
+fido2>=0.9.1
 okta>=0.0.4,<1.0.0
 ctap-keyring-device>=1.0.4
chjones commented 3 years ago

I linked #12, I believe this issue can be closed.