WarperSan / ShipInventory

1 stars 1 forks source link

[Incompatibility] ShipInventory doesn't handle Shopping Cart deposits #19

Open ajsglist opened 1 month ago

ajsglist commented 1 month ago

Describe the bug Hey there, I've been testing out Ship Inventory and it's a really handy mod. We noticed today that (perhaps expectedly) depositing the Shopping Cart with items inside of it is unsupported.

Currently, depositing a Shopping Cart containing items will properly deposit the Shopping Cart but will ignore any contained items since ShipInventory doesn't expect it to be a container. Probably also happens with the Wheelbarrow (haven't tested yet).

I've gone ahead and blacklisted both of these items since I don't personally find value in depositing them, but I wanted to report the issue to you since I had found it.

To Reproduce Find ShoppingCart, place at least one item in it, and then deposit into ShipInventory as usual

Expected behavior (Optional) Ideally ShipInventory would either internally blacklist the ShoppingCart + Wheelbarrow or alternatively it would recognize them as containers and make sure to properly deposit the contained items.

Screenshots N/A

Mods used https://thunderstore.io/c/lethal-company/p/WhiteSpike/Shopping_Cart/

Additional context Happy to provide anything else you might need. Cheers

ajsglist commented 1 month ago

A more interesting bug has also manifested as a result, haha.

The player weight for the depositing player is observed to bug out when the shopping cart is deposited, and then withdrawn and used.

For instance, the deposited shopping cart totaled 69lbs with items. However the base weight is something like 25lbs. So when picking up the shopping cart the player weight is set to 69lbs as if the shopping cart is still full (because ShipInventory appears to have thought the item weight was 69lbs). But then when dropping the shopping cart, 25lbs is subtracted and a player with no items equipped has an encumbrance of 44lbs

image image

ajsglist commented 1 month ago

one more bug to report: dropping items onto the chute seems to get them stuck, at least in the case of a small item like the pro flashlight. Does one of the current settings help with this (I'm a little unclear on a few of them, sorry if it should be obvious)

image

ajsglist commented 1 month ago

we're also planning on blacklisting the belt bag, but just a heads up that when we deposited and withdrew a belt bag, it seems to be stuck and can't be interacted with. When we did finally pick it up (by using another belt bag), it was observed that it also had its stored test item removed similar to the Shopping Cart bug reported in OP.

Cheers

image