WarrenLab / hic-scaffolding-nf

Nextflow pipeline for scaffolding genome assemblies with Hi-C reads
MIT License
12 stars 3 forks source link

add a way to specify the restriction enzyme in yaHS with -e #2

Closed uqunakan closed 1 year ago

uqunakan commented 1 year ago

Hi, could you please let me know what's the default restriction enzyme used for YaHS tool in this pipeline? Because when we manually run YaHS, we can change it with the -e option. We should be able to specify the restriction enzyme(s) used by the Hi-C experiment (GATC,GANTC etc). In my case GATC is the restriction enzyme used in our HiC experiment.

Do we need to change nf main file? If so, how to change it and locally run it?

esrice commented 1 year ago

I haven't added a way to specify a -e option to yahs. I'll put it on my to-do list, should be pretty quick. In the meantime, you can copy the main.nf script to the directory where you want to run it and then edit the yahs command manually.

uqunakan commented 1 year ago

Thank you very much for your response, Edward. I will try to do it.

Thanks and regards,

Ms Upuli Nakandala | PhD student Robert Henry’s Lab Queensland Alliance for Agriculture & Food Innovation Level 6 Hartley Teakle Building [609] The university of Queensland, St Lucia QLD 4072 Email: @.**@.> Mobile: +61480385195 Website: www.qaafi.uq.edu.auhttp://www.qaafi.uq.edu.au

From: Edward S. Rice @.> Sent: Saturday, 15 April 2023 7:39 PM To: WarrenLab/hic-scaffolding-nf @.> Cc: Upuli Nakandala @.>; Author @.> Subject: Re: [WarrenLab/hic-scaffolding-nf] changing the restriction enzyme in yaHS tool with -e option (Issue #2)

I haven't added a way to specify a -e option to yahs. I'll put it on my to-do list, should be pretty quick. In the meantime, you can copy the main.nf script to the directory where you want to run it and then edit the yahs command manually.

— Reply to this email directly, view it on GitHubhttps://github.com/WarrenLab/hic-scaffolding-nf/issues/2#issuecomment-1509704109, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVJZUNO4UCE7GF5D646RRE3XBJUCZANCNFSM6AAAAAAW7E3IRY. You are receiving this because you authored the thread.Message ID: @.***>

esrice commented 1 year ago

Alright, I added with the latest commit a way to specify addition arguments to yahs. Try

nextflow WarrenLab/hic-scaffolding-nf -latest -r 6faa2fc [your arguments] --extra-yahs-args "-e GATC"

(the -latest -r 6faa2fc part is to make sure it uses the most recent version of the pipeline)

uqunakan commented 1 year ago

Hi Edward, I edited the yahs command with -e GATC option in the main.nf script which I have previously installed. Since the command is there now in the main.nf script, I suppose I don’t need to add it to the following command (red colour) which I use to run this script. Am I correct?

nextflow run WarrenLab/hic-scaffolding-nf -profile conda --juicer-tools-jar /scratch/project/qaafi-cnafs/hic-scaffolding-nf/juicer_tools_1.22.01.jar --contigs C.australasica_Rainbow.asm.hic.p_ctg.fa --r1Reads combined_R1.fastq --r2Reads combined_R2.fastq -e GATC

Thanks and regards,

Ms Upuli Nakandala | PhD student Robert Henry’s Lab Queensland Alliance for Agriculture & Food Innovation Level 6 Hartley Teakle Building [609] The university of Queensland, St Lucia QLD 4072 Email: @.**@.> Mobile: +61480385195 Website: www.qaafi.uq.edu.auhttp://www.qaafi.uq.edu.au

From: Edward S. Rice @.> Sent: Saturday, 15 April 2023 7:39 PM To: WarrenLab/hic-scaffolding-nf @.> Cc: Upuli Nakandala @.>; Author @.> Subject: Re: [WarrenLab/hic-scaffolding-nf] changing the restriction enzyme in yaHS tool with -e option (Issue #2)

I haven't added a way to specify a -e option to yahs. I'll put it on my to-do list, should be pretty quick. In the meantime, you can copy the main.nf script to the directory where you want to run it and then edit the yahs command manually.

— Reply to this email directly, view it on GitHubhttps://github.com/WarrenLab/hic-scaffolding-nf/issues/2#issuecomment-1509704109, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVJZUNO4UCE7GF5D646RRE3XBJUCZANCNFSM6AAAAAAW7E3IRY. You are receiving this because you authored the thread.Message ID: @.***>

esrice commented 1 year ago

You can either use the most recent version on github (by adding the -latest -r 6faa2fc arguments) plus the --extra-yahs-args "-e GATC" arguments, or you can run the command the way you originally did with the edited main.nf.

uqunakan commented 1 year ago

Hi Edward. Thank you very much. I also need to know whether this pipeline performs any Arima mapping to do 5’ filtering of chimeric reads and to remove PCR duplication of HiC reads. In the main.nf script, I found nothing related to Arima mapping. So, I suppose it only aligns HiC reads to the contig.fa file and the resulting output BAM file is scaffolded with YaHS tool. Is it correct?

Thanks and regards,

Ms Upuli Nakandala | PhD student Robert Henry’s Lab Queensland Alliance for Agriculture & Food Innovation Level 6 Hartley Teakle Building [609] The university of Queensland, St Lucia QLD 4072 Email: @.**@.> Mobile: +61480385195 Website: www.qaafi.uq.edu.auhttp://www.qaafi.uq.edu.au

From: Edward S. Rice @.> Sent: Monday, 17 April 2023 8:18 PM To: WarrenLab/hic-scaffolding-nf @.> Cc: Upuli Nakandala @.>; Author @.> Subject: Re: [WarrenLab/hic-scaffolding-nf] add a way to specify the restriction enzyme in yaHS with -e (Issue #2)

You can either use the most recent version on github (by adding the -latest -r 6faa2fc arguments) plus the --extra-yahs-args "-e GATC" arguments, or you can run the command the way you originally did with the edited main.nf.

— Reply to this email directly, view it on GitHubhttps://github.com/WarrenLab/hic-scaffolding-nf/issues/2#issuecomment-1511077454, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVJZUNI4RJDPQAG3TXAZTITXBUKETANCNFSM6AAAAAAW7E3IRY. You are receiving this because you authored the thread.Message ID: @.**@.>>

esrice commented 1 year ago

This pipeline uses chromap for alignment and postprocessing (dealing with pairs, chimeras, duplicates etc.) rather than arima. You can take a look at the documentation of both of these for more information on how the approaches differ.

uqunakan commented 1 year ago

Thank you very much Edward.

Best regards,

Ms Upuli Nakandala | PhD student Robert Henry’s Lab Queensland Alliance for Agriculture & Food Innovation Level 6 Hartley Teakle Building [609] The university of Queensland, St Lucia QLD 4072 Email: @.**@.> Mobile: +61480385195 Website: www.qaafi.uq.edu.auhttp://www.qaafi.uq.edu.au

From: Edward S. Rice @.> Sent: Monday, 17 April 2023 9:25 PM To: WarrenLab/hic-scaffolding-nf @.> Cc: Upuli Nakandala @.>; Author @.> Subject: Re: [WarrenLab/hic-scaffolding-nf] add a way to specify the restriction enzyme in yaHS with -e (Issue #2)

This pipeline uses chromap for alignment and postprocessing (dealing with pairs, chimeras, duplicates etc.) rather than arima. You can take a look at the documentation of both of these for more information on how the approaches differ.

— Reply to this email directly, view it on GitHubhttps://github.com/WarrenLab/hic-scaffolding-nf/issues/2#issuecomment-1511164630, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVJZUNL5LFMGYK4M2BLHGWLXBUSCBANCNFSM6AAAAAAW7E3IRY. You are receiving this because you authored the thread.Message ID: @.***>