search

WarrenWeckesser / wavio

A Python module for reading and writing WAV files using numpy arrays.
133 stars 19 forks source link

Fixed int16 overflow #6

Closed BebeSparkelSparkel closed 6 years ago

BebeSparkelSparkel commented 6 years ago

Fixed int16 overflow by using int64.

Removed the use of "file" because it is a built in python function.

updated docs to have consistent input arguments

WarrenWeckesser commented 6 years ago

Thanks! It will probably be a few days before I can review this.

BebeSparkelSparkel commented 6 years ago

Any chance to look at this yet?

WarrenWeckesser commented 6 years ago

William, thanks again for reporting the problem and submitting this pull request. Sorry that "a few days" turned into a few weeks.

I decided to fix the problem in a slightly different way than you suggested here. I've pushed my changes, so I'm closing this pull request. I'll also likely incorporate some of the other cosmetic changes that you made, so thanks for those, too!

BebeSparkelSparkel commented 6 years ago

You're welcome for cosmetic changes Thanks for getting around to it