search

WarwickCIM / ways-py

Python package for the WAYS project.
https://pypi.org/project/ways-py/
GNU General Public License v3.0
1 stars 2 forks source link

Refactor altair widgets to reflect that scale and bin can only be used independently #76

Closed edwardchalstrey1 closed 2 years ago

edwardchalstrey1 commented 3 years ago

By turning the legend on again, I've discovered that unfortunately setting the type within an alt.Scale object actually sets up a continuous scale which overwrites the bin when both the alt.Bin and alt.Scale objects are used to create the alt.Color object in WAlt.get_altair_color_obj. What this means is that the charts in the notebooks have been using a continuous colour scale that doesn't match what is shown on the "colours used plot" which displays the unused binned colour scale. We should probably update the widget options to reflect that only either "binning" or "scale" can be used at once.

Screenshot 2021-11-26 at 13 42 40

t

edwardchalstrey1 commented 3 years ago

This should probably be fixed before we try to make a continuous version of the colours used plot #63