Closed inodlite closed 5 years ago
Hi. I'm a bit confused as to where all these old commits come from?
I can build both the old WMIT and one patched with the above commits here if I add -lGL to the CMakeLists.txt link line, but I can only run the old one. The patched version hangs forever in the shader linking stage. Any idea why?
(Also the MATERIALS directive no longer does anything. Instead we have other options, like adding separate shaders for each model.)
Hi,
All but last commit were sitting in my fork (based on Emdek’s fork) since dawn of time.
Recently I saw that someone mentioned updating wmit to qt5 and I finally managed to upload that exact change and made a PR.
I’ve only used QtCreator and .pro files to build it and it usually works oob, unless you have custom path to libQGLViewer. That can be overridden in config.pri. I can’t comment on CMake stuff unfortunately.
To my knowledge, shader here is an exact copy of one from 3.1, so I’m surprised about issue that you’re experiencing. It used to work fine for me back at the day and it worked perfectly in a vanilla Fedora 28 VM with llvmpipe when I build it yesterday.
I don’t recall the specifics anymore, but I think that wmit only saves those extra directives if they were present when loading file. Feel free to delete stuff that doesn’t really matter anymore, as I’m obviously not up to date on that.
@inodlite: I'd like to see if we can get all these improvements merged (and the additional ones from your fork). Ideally, we'd get things set up so we could have automated builds for all platforms (or, at least, Windows and macOS) - probably need to rework the CMake build setup for that, which also might make it easier to build on Linux.
I had no issues building WMIT using qmake in Fedora both natively or with their mingw compiler. I only have a small patch for QGLViewer when cross-compiling, which I can commit for other Fedora users. So if there is a CI with Fedora images available than it should be pretty trivial to put a build script together.
I don't use CMake with WMIT nor do I do dev with CMake, so I can't say much about its state. If someone steps in to update those it would be great, though...
When I have a chance, I will take a look at what needs to happen to get CMake builds working again. (This would probably be the best route to getting macOS builds working again - similar to what we did with WZ.)
Most important ones are: support for Qt5 and pie format from wz3.1.
It allows you you to select a custom shader and reload it as needed, but support for wz 3.2 attributes is not there. Should not be hard to add later.
Compiles in Fedora 28 with Qt 5.10 with QGLViewer 2.6.4 (from source). QGLViewer 2.7 might introduce some breaking changes...