Fix for gui-less terrain properly

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac

0 stars 0 forks source link

Fix for gui-less terrain properly #1692

Closed wzdev-ci closed 14 years ago

wzdev-ci commented 14 years ago

resolution_fixed type_patch (an actual patch, not a request for one) | by Safety0ff

Added multiplicative blending to iVis blending wrapper, because some code was changing the state without using the wrapper.

Added a pie_SetRendMode(Rend_Opaque) that was missed.

Issue migrated from trac:1692 at 2022-04-15 21:13:49 -0700

wzdev-ci commented 14 years ago

Safety0ff changed title from Fix for gui-less terrain that broke in r10209 to Fix for gui-less terrain properly

wzdev-ci commented 14 years ago

Safety0ff commented

Update:

Revert [9629].

Replaced two texture changing calls with their iVis equivalents.

wzdev-ci commented 14 years ago

Safety0ff uploaded file guilessfix.diff (3.2 KiB)

wzdev-ci commented 14 years ago

dak180 commented

guilessfix.diff does not break the mac build.

wzdev-ci commented 14 years ago

i-NoD commented

A good one. Apply it.

As a side note: there is a superfluous transMode assignment in TRANS_DECAL case of pie_SetTranslucencyMode():

 rendStates.transMode = TRANS_DECAL;

You may remove it as well.

wzdev-ci commented 14 years ago

safety0ff commented

(In [10381]) Fixed terrain drawing code that was making the iVis state invalid.

Added multiplicative blending mode.
Reverted [9629]. Reviewed by i-NoD. Closes #1692.

wzdev-ci commented 14 years ago

safety0ff changed status from new to closed

wzdev-ci commented 14 years ago

safety0ff set resolution to fixed

wzdev-ci commented 14 years ago

Git SVN Gateway gateway@... commented

(In https://github.com/Warzone2100/warzone2100/commit/ad27f1b309cdd171e633f423c90f7209d68a12a1) Fixed terrain drawing code that was making the iVis state invalid.

Added multiplicative blending mode.
Reverted [9629]. Reviewed by i-NoD. Closes #1692.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10381 4a71c877-e1ca-e34f-864e-861f7616d084

wzdev-ci commented 14 years ago

Git SVN Gateway gateway@... commented

In https://github.com/Warzone2100/warzone2100/commit/ad27f1b309cdd171e633f423c90f7209d68a12a1:

#CommitTicketReference repository="" revision="ad27f1b309cdd171e633f423c90f7209d68a12a1"
Fixed terrain drawing code that was making the iVis state invalid.
- Added multiplicative blending mode.
- Reverted [9629].
Reviewed by i-NoD.
Closes #1692.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10381 4a71c877-e1ca-e34f-864e-861f7616d084

wzdev-ci commented 12 years ago

cybersphinx changed milestone from 3.0 to unspecified

wzdev-ci commented 12 years ago

cybersphinx commented

Milestone 3.0 deleted