Closed wzdev-ci closed 13 years ago
cybersphinx uploaded file scanlines.patch
(2.9 KiB)
cybersphinx uploaded file scanlines.png
(164.5 KiB)
Buginator commented
Looks good, when I did this, I didn't do your 1/2 (R|G|B) color for the odd scan line, it does make it look better.
However, I also noticed that we would still need two routines for this, since we don't want all the vids to use scanlines (the intel ones).
cybersphinx commented
If the small videos are shown 1:1 they'll just be 25% darker. But what I also noticed, the scanlines make the subtitle text harder to read.
cybersphinx commented
Add an option for scanlines when playing videos.
Shows either no, 50% dimmed or black scanlines. Disabled if the video texture is too small (needs 2 * video height), or the video is shown so small that the scanlines can't be noticed.
Refs #2095, #2686. Changeset: f934b1bfc36a8e6de0ef3da4dddbdb4b5bc04bf8
cybersphinx changed status from new
to closed
cybersphinx changed resolution from ` to
fixed`
cybersphinx commented
Merged into 2.3 in 689e73b79197b76184d80280a7fc19f955f9b2d0.
resolution_fixed
type_patch (an actual patch, not a request for one)
| by cybersphinxThis patch adds scanlines for the videos by doubling the vertical texture size and repeating every line with the pixel values reduced by 50%. Proof of concept atm.
Issue migrated from trac:2095 at 2022-04-15 22:14:39 -0700