search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

3.0 <-> master diffs (pies / stats / pngs) #2393

Closed wzdev-ci closed 11 years ago

wzdev-ci commented 13 years ago

resolution_closed type_patch (an actual patch, not a request for one) | by Buginator

3.0 <-> master diffs

These are the ones that will be merge... Some of the stat files I put up, since I wasn't sure about the changes. The png changes are also in the patch (I hope trac don't puke on that patch.)

Issue migrated from trac:2393 at 2022-04-16 06:51:55 -0700

wzdev-ci commented 13 years ago

Buginator uploaded file 0003-Diffs-3.0-master.patch (3.1 KiB)

wzdev-ci commented 13 years ago

Buginator uploaded file 0001-NOTE-This-is-all-the-pie-changes-that-were-ever-in-3.patch (325.8 KiB)

wzdev-ci commented 13 years ago

Buginator uploaded file 0002-The-masks-from-last-commit-that-were-changed.patch (36.1 KiB)

wzdev-ci commented 13 years ago

Buginator edited the issue description

wzdev-ci commented 13 years ago

Per commented

The 0003 stats changes look suspicious to me. Well, besides the removal of the plasmite bomber, which is just dead wrong.

The 0001 pie changes I do not understand. I was pretty sure all models in master already used tcmask?

wzdev-ci commented 13 years ago

Safety0ff commented

Hmmm, I think the 4200 flags were removed from trunk (by simplipie,) and that's why those changes are showing up in the patch.

As you can see, the majority of the changes are NOT adding TCMask flag addition (10200).

So for patch # 0001 I'd ignore the 200 -> 4200 flag changes, and I'd review the remaining changes to make they make sense with trunk.

e.g. Whether the texture name changes are valid, etc

wzdev-ci commented 11 years ago

Cyp commented

3.0? What's that? Is this ticket still useful?

wzdev-ci commented 11 years ago

vexed changed status from new to closed

wzdev-ci commented 11 years ago

vexed changed resolution from ` toclosed`

wzdev-ci commented 11 years ago

vexed commented

Replying to Warzone2100/old-trac-import#2393 (comment:4):

3.0? What's that? Is this ticket still useful?

Sure, but my delorean is out of gas, so I can't fix it.