search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

Cannot create some units in design GUI if all weapons are researched #3160

Closed wzdev-ci closed 12 years ago

wzdev-ci commented 12 years ago

resolution_fixed type_patch (an actual patch, not a request for one) | by Reg312

Test steps

1) Start game and enter cheat "research all"

i assume this cheat equal to situation when player really researched all

2) Open GUI unit designer and select tank with tracked propulsion

3) Try find weapon "Stormbringer AA Laser"

error: some weapons cannot be designed

-ligh cannot

-Stormbringer AA Laser

problem: reached limit of 32 weapons

Issue migrated from trac:3160 at 2022-04-16 08:53:54 -0700

wzdev-ci commented 12 years ago

vexed changed status from new to closed

wzdev-ci commented 12 years ago

vexed changed resolution from ` tolater`

wzdev-ci commented 12 years ago

vexed commented

This isn't a bug, this is a feature request. We don't support anything with cheats, since, as you can see there is a limit, and nobody has had time to remove the limit.

It is easy enough to fix, the comments are inline in the code.

wzdev-ci commented 12 years ago

Reg312 changed _comment0 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment1 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment5 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment2 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment3 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment4 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment6 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment7 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment8 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment9 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment10 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 changed _comment11 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 commented

patch: https://github.com/crabster/warzone2100/commit/60fb815bf3890724ec9479bd41445dd18a3e1725

Test with additional 40 weapons:

1) Put attached files into wz data dir

2) Start WZ, cheat "give all"

3) Check list of weapons in uni designer (added 40 sttormbringer lasers with name '123')

problem: possibly incorrect switching to small tabs in some cases (count of buttons takes into account both vtol and ground weapons, it will be fixed later, need add types of weapons: standard/cyborg/vtol)

wzdev-ci commented 12 years ago

Reg312 changed _comment12 which not transferred by tractive

wzdev-ci commented 12 years ago

Reg312 uploaded file weapons.txt (43.5 KiB)

wzdev-ci commented 12 years ago

Reg312 uploaded file names.txt (77.5 KiB)

wzdev-ci commented 12 years ago

vexed changed status from closed to reopened

wzdev-ci commented 12 years ago

vexed changed resolution from later to ``

wzdev-ci commented 12 years ago

vexed changed type from bug to patch (an actual patch, not a request for one)

wzdev-ci commented 12 years ago

Shadow Wolf TJC changed _comment0 which not transferred by tractive

wzdev-ci commented 12 years ago

Shadow Wolf TJC commented

It seems as if, without cheating, you could technically have up to 34 different weapons (assuming that NEXUS Link Turrets and EMP Cannons also count as one) to choose from when designing a ground unit (assuming that older weapons, such as Machineguns and Flamers, are removed from the list as they become obsolete through research of more advanced weapons, such as Assault Guns and Infernos), though this would require LOTS of researching. If we're not going to bother expanding the limit on how many weapons can be selected from the design menu to somewhere well above 32 (which is something that I'd like to support strongly), then we might have to make some more weapons obsolete as new technologies are discovered, such as making the Light Cannon obsolete when the Assault Cannon is researched, and making the Mini-Rocket Array obsolete once the Seraph Missile Array is researched.

wzdev-ci commented 12 years ago

Reg312 commented

this restriction of 32 weapons just is prison of game. my goal - is make game more adaptive, make possibility to create more various mods and extensions etc... so i'm still waiting when my patch will be approved, but i have impatience

wzdev-ci commented 12 years ago

Shadow Wolf TJC commented

Replying to Warzone2100/old-trac-import#3160 (comment:6):

this restriction of 32 weapons just is prison of game. my goal - is make game more adaptive, make possibility to create more various mods and extensions etc... so i'm still waiting when my patch will be approved, but i have impatience I sure hope that this patch gets approved as well. I'd like to add a few new weapons for a mod that I'm working on, many of which I fear I cannot replace other, less-powerful weapons, with given their unique roles and prerequisites.

wzdev-ci commented 12 years ago

Shadow Wolf TJC commented

Replying to Warzone2100/old-trac-import#3160 (comment:2):

problem: possibly incorrect switching to small tabs in some cases (count of buttons takes into account both vtol and ground weapons, it will be fixed later, need add types of weapons: standard/cyborg/vtol) Perhaps you may need to tell the script to check to see if 1. the turret's designable variable is set to "1" or "TRUE", and 2. the turret's numAttackRuns variable is set to "0" (IF the vehicle being designed is not a VTOL. Otherwise, if the vehicle being designed IS a VTOL, then check to see if numAttackRuns is greater than 0). If either check is FALSE, then we can just skip it and check the next turret in line.

I hope that this will help. :)

wzdev-ci commented 12 years ago

crabster changed status from reopened to closed

wzdev-ci commented 12 years ago

crabster changed resolution from ` tofixed`

wzdev-ci commented 12 years ago

crabster commented

Extending components limit in unit design GUI

Fixes #3160 Limit of components to design increased to 128.

wzdev-ci commented 12 years ago

crabster commented

Extending components limit in unit design GUI

Fixes #3160 Limit of components to design increased to 128.

wzdev-ci commented 12 years ago

Shadow Wolf TJC commented

Looks like this patch works nicely. Sadly, it seems as if structures.txt has a limit of around 256 structures, which may be too small to support enough defenses to make use of all these weapons.

wzdev-ci commented 12 years ago

crabster commented

Extending components limit in unit design GUI

Fixes #3160 Limit of components to design increased to 128.