search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

Fixing password protected login with --join= #3308

Open wzdev-ci opened 12 years ago

wzdev-ci commented 12 years ago

keyword_join_cli_password type_patch (an actual patch, not a request for one) | by linus.luessing@...

See attached patch.

Issue migrated from trac:3308 at 2022-04-16 09:37:29 -0700

wzdev-ci commented 12 years ago

anonymous uploaded file .0001-Fixing-password-protected-login-with-join.patch.swp (12.0 KiB)

wzdev-ci commented 12 years ago

anonymous uploaded file 0001-Fixing-password-protected-login-with-join.patch (2.8 KiB)

woops, this is the patch

wzdev-ci commented 12 years ago

linus.luessing@... uploaded file 0002-Fixing-password-protected-login-via-ip-connection-sc.patch (1.6 KiB)

And trying to fix the same issue for the ip connection screen too

wzdev-ci commented 12 years ago

linus.luessing@... commented

Furthermore I'm still seeing the following two race conditions from time to time:

When sending a wrong password to the host (either because I misstyped it or because it was the first connection attempt) I sometimes get an "Incorrect Password" in the GUI and sometimes I can retry the password. Which of these two is the intended behaviour?

Secondly if I'm not hitting the Enter key after typing the password, I think I'm sometimes seeing a race condition between CON_PASSWORD and CON_PASSWORDYES: When that happens the latter in runGameFind() is being processed without a prior CON_PASSWORD, therefore the client then sends the default/wrong password to the host. But I cannot reproduce this at the moment...

wzdev-ci commented 12 years ago

vexed commented

I suppose we can add a command line option of --password=... as well...