search

Warzone2100 / old-trac-import

Archived Import of (old) Warzone 2100 Trac
0 stars 0 forks source link

Default map: Use correct number of players #4849

Closed wzdev-ci closed 5 years ago

wzdev-ci commented 5 years ago

resolution_fixed type_patch (an actual patch, not a request for one) | by Kreuvf

The patch in #4848 made the game use an already defined constant for the default map to show for skirmish games. Unfortunately, maps are not always loaded equally. Here, this means that the number of players is not read from the map, but is as hardcoded as the default map.

To fix the number of slots to use the actual number of players, I introduce the (rather ugly) DEFAULTSKIRMISHMAPMAXPLAYERS constant defined right where you would expect it: next to the definition of the default skirmish map.

While the patch is for 3.2.3, this should apply cleanly to master as well.

Issue migrated from trac:4849 at 2022-04-16 13:33:35 -0700

wzdev-ci commented 5 years ago

Kreuvf uploaded file ease-changing-default-map-maxplayers.patch (2.0 KiB)

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... changed status from new to closed

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... changed owner from ` toSteven Koenig kreuvf@gna.org`

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... changed resolution from ` tofixed`

wzdev-ci commented 5 years ago

Steven Koenig kreuvf@... committed [5807]

In https://github.com/Warzone2100/warzone2100/commit/5807d38b51120e8782609f3b28d348624647f306:

#CommitTicketReference repository="" revision="5807d38b51120e8782609f3b28d348624647f306"
Ease changing default map maxplayers.

Closes ticket 4849.
wzdev-ci commented 5 years ago

Berserk Cyborg changed blocking which not transferred by tractive

wzdev-ci commented 5 years ago

Berserk Cyborg changed blockedby which not transferred by tractive

wzdev-ci commented 5 years ago

Berserk Cyborg commented

Thanks!

BTW, you had the default set to 2 so I changed it to 4 since Rush is the official default map. :)

wzdev-ci commented 5 years ago

Kreuvf commented

Replying to Warzone2100/old-trac-import#4849 (comment:2):

BTW, you had the default set to 2 so I changed it to 4 since Rush is the official default map. :)

Good catch xD

The patch originates from a mod project with a two-player map as the default map, so that's the simple reason behind it.