Change radar size calculation

[wzdev-ci]

resolution_fixed type_patch (an actual patch, not a request for one) | by Forgon

---

The simplified radar size calculation introduced in ticket #4689 led to many user complaints about the radar being:

• too small
• partly outside of the game window when rotating it
• of different sizes in pre-offworld and offworld missions

Just as before commit 619e84d56189f45138ff18b3aea733dc15d9ca0c the radar should

• be centered when rotating to avoid breaking the game window
• be scaled down to a predefined size rather than tile size

Different radar sizes change their meaning:

• size 8 is now equal to the size of the reticule area in the lower left corner of the screen, without breaking the layout in any way whatsoever.
• size 48 is the new default size and equal to 30% of the screen width.

In addition, the radar's offset from the lower right corner of the game window has been decreased so that it visually aligns with other widgets.

Unfortunately, preventing rotating radar from being partially outside of the game window requires to increase its side length by the square root of 2 and looks irritating. I have nevertheless implemented this change so that I can get feedback on how exactly radar rotation is supposed to behave.

---

Issue migrated from trac:4869 at 2022-04-16 13:35:01 -0700

[wzdev-ci]

Forgon _uploaded file radar_size_calculation.patch (2.8 KiB)_

patch file based on revision 53e675d42a4025b9106ff46c7687db90179160a2

[wzdev-ci]

Berserk Cyborg commented

---

Tried your patch. Yeah, rotating radar doesn't look all that great, especially with maps which have a substantially longer side (like Startup). It also unnecessarily steals a portion of the bottom right corner if untouched.

What about recentering/shifting the mini-map just enough to stay inside the window border(s) if a part of it is outside the window?

[wzdev-ci]

Forgon commented

---

Replying to Warzone2100/old-trac-import#4869 (comment:1):

Tried your patch. Yeah, rotating radar doesn't look all that great, especially with maps which have a substantially longer side (like Startup). It also unnecessarily steals a portion of the bottom right corner if untouched.

What about recentering/shifting the mini-map just enough to stay inside the window border(s) if a part of it is outside the window? As of yet, the best idea I have is multiplying the side length of rotating minimaps by sqrt(sqrt(2)) rather than sqrt(2). It certainly looks better.

Of course, this results in a small part of the minimap being outside the window during rotation.

[wzdev-ci]

Berg changed _comment0 which not transferred by tractive

[wzdev-ci]

Berg commented

---

for [07:46] Quenton please change back to 3.1.5 style [07:46] Quenton this no good for lots of maps

[wzdev-ci]

Berserk Cyborg changed status from new to closed

[wzdev-ci]

Berserk Cyborg changed resolution from ` tofixed`

[wzdev-ci]

Berserk Cyborg commented

---

Reverted commit 17218fb55139a40f5ebd52df96b5ada47bd03bac.