search

WasabiThumb / xclaim

A better chunk claiming system for Paper servers
Mozilla Public License 2.0
19 stars 10 forks source link

[bug] trusted players page can completely crash the server #135

Closed gocciolafr closed 1 month ago

gocciolafr commented 1 month ago

how to reproduce:

  1. go to the trusted players page
  2. press add player
  3. type random name, for example "hello" (this is the one that made the server crash)
  4. when the player is added simply click on the player head
  5. after this the server crashes.
gocciolafr commented 1 month ago

i just noticed that almost everything you can type to the name, even if it is a real player it crashes the server. can you please push an update that temporarily removes this feature until fixed?

WasabiThumb commented 1 month ago

how to reproduce:

  1. go to the trusted players page
  2. press add player
  3. type random name, for example "hello" (this is the one that made the server crash)
  4. when the player is added simply click on the player head
  5. after this the server crashes.

What is the stack trace/thread dump produced? Can you share a log?

RHX0R3 commented 1 month ago

Stumbled upon the same error. Thats quite fatal :(.

HERE is my stacktrace when it's crashed.

Krayir5 commented 1 month ago

yeah it got fixed in the codes but i guess he didn't build it publicly, you can build the plugin yourself by just downloading and using maven it'll be fixed

WasabiThumb commented 1 month ago

yeah it got fixed in the codes but i guess he didn't build it publicly, you can build the plugin yourself by just downloading and using maven it'll be fixed

Correct, based on the stack trace it's clear that they aren't using the patched code introduced by commit b314773. I thought I included it in a public build, but I guess not. It was almost a month ago now, in my defense.

I'll do a little testing to make sure that I was wrong to not publish this patch.

WasabiThumb commented 1 month ago

Which is to say that this is a duplicate of #128, you can reference that issue if you need a patched build immediately.

WasabiThumb commented 1 month ago

lgtm, should be fixed in 1.14.1