search

WasatchPhotonics / ENLIGHTEN

Open-source spectroscopy application for controlling and taking measurements from Wasatch Photonics spectrometers.
https://wasatchphotonics.com/product-category/software/
MIT License
3 stars 6 forks source link

"Turn Laser Off" button found not red #299

Closed samiebee43 closed 6 months ago

samiebee43 commented 11 months ago

ENLIGHTEN BUG: I saw the "Turn Laser Off" on ENLIGHTEN when the button wasn't red...that button should always be red when the laser is firing (and it was definitely firing). The StatusIndicators were all gray (disabled) as well.

samiebee43 commented 11 months ago

Need a unit with a laser to test and fix this. @mzieg

Note this issue came before the new themes addition, but it would be worthwhile to make sure the button is still red while running the blue theme for example.

mzieg commented 11 months ago

I just saw this on ENLIGHTEN 4.0.17 while/after using the BurnIn plug-in.

Dark button didn't change red either.

DOES seem to be working on 4.0.24.

samiebee43 commented 11 months ago
image
mzieg commented 11 months ago

I think this relates to run-BurnIn.bat running from C:\Users\foo\Documents\EnlightenSpectra\plugins\Prod, and therefore failing to load external relative CSS files. Problem was observed in ENLIGHTEN 4.0.17, probably already fixed in 4.1.0-dev.

samiebee43 commented 10 months ago

Oh that would make sense, the logic is there to change the css file, but if the file is missing: no style.

This would be a good place to use inline styles, so the red-ness of the button is not dependent on style files.

mzieg commented 6 months ago

closing for now, pending fresh observations