search

WasatchPhotonics / ENLIGHTEN

Open-source spectroscopy application for controlling and taking measurements from Wasatch Photonics spectrometers.
https://wasatchphotonics.com/product-category/software/
MIT License
3 stars 6 forks source link

Remove FWHM from Local Baseline Plugin on main #316

Closed samiebee43 closed 10 months ago

samiebee43 commented 10 months ago

Overall I want to retire my FWHM program.

It's not well written, and it strains the already barely working plugin/annotation system. The approach is okay, and the in-line diagrams are nice in my opinion, but the use of relative indices (continuing from Local Baseline's use of the same) makes it bug prone and difficult to maintain.

Nobody is depending on this program afaik, and I would like to remove it before that changes. It's due for a rewrite--best kept separate from Local Baseline (because of the relative indices problem).

mzieg commented 10 months ago

I'm okay with removing the FWHM functionality from it, but I'd leave the LocalBaseline.py file in the pluginExamples/Analysis directory. It looks like it got deleted and re-added at the root?

Edit: actually, it looks like the modified version is still in Analysis/, but there's a new copy added to the root folder?

samiebee43 commented 10 months ago

Thanks for catching that !