WasatchPhotonics / ENLIGHTEN

Open-source spectroscopy application for controlling and taking measurements from Wasatch Photonics spectrometers.
https://wasatchphotonics.com/product-category/software/
MIT License
3 stars 6 forks source link

Remove console window from Windows executables #430

Closed mzieg closed 2 weeks ago

mzieg commented 2 weeks ago

Final PR:

Original branch intention:

Was testing a Tensorflow model, and perhaps my laptop was just under unusually high strain, but it failed while loading the model and logged this message:

tensorflow DEBUG Falling back to TensorFlow client; we recommended you install the Cloud TPU client directly with pip install cloud-tpu-client

(Note message was emitted directly from the tensorflow library, which was interesting.) I added this package, and everything ran perfectly.

mzieg commented 2 weeks ago

This was interesting, but didn't really explain why this happened now or how the tpu package "fixed" it (if it did):

https://cloud.google.com/tpu/

My guess is:

  1. This was the first time I tried using TF on a new (to me, but circa 2019) laptop -- perhaps the HW either had something extra, or something missing, from my usual test station; or

  2. Adding the tpu was unnecessary, the TF log was a red herring, and all I really needed was to reboot and try again. It happens. Still this seems a harmless and potentially useful update.

mzieg commented 2 weeks ago

Just capturing some notes here. I started getting Microsoft Defender Anti-Virus warnings about ENLIGHTEN (not when running the installer, but when running the executable installed by the installer) after adding cloud-tpu-client, and the warnings went away when I removed it again. I'm not declaring cloud-tpu-client as the malware cause (I was fiddling with various other things including Python version, matplotlib version, TF version, pyinstaller settings etc) but it may have been.

Trying now with --noconsole.

mzieg commented 2 weeks ago
Screenshot 2024-06-19 at 12 38 36 PM

https://www.microsoft.com/en-us/wdsi/threats/malware-encyclopedia-description?name=Trojan%3AWin32%2FWacatac.B!ml&threatid=2147735505

mzieg commented 2 weeks ago
image
mzieg commented 2 weeks ago

Addresses #309