search

Washi1337 / AsmResolver

A library for creating, reading and editing PE files and .NET modules.
https://docs.washi.dev/asmresolver/
MIT License
848 stars 127 forks source link

Set Accessors for Semantic Methods #555

Closed ds5678 closed 4 months ago

ds5678 commented 4 months ago

Should these set accessors modify MethodDefinition.Semantics too?

Washi1337 commented 4 months ago

This should be already handled by MethodSemanticsCollection. If not, then this should be considered a bug.

ds5678 commented 4 months ago

This should be already handled by MethodSemanticsCollection. If not, then this should be considered a bug.

This is correct. I added a unit test to make sure.

Washi1337 commented 4 months ago

Thanks for verifying!