Open ElektroKill opened 2 years ago
This is a direct result of https://github.com/Washi1337/OldRod/blob/a8dfa553769f5fcef3c5f2338242fa1561525acd/src/OldRod.Core/Recompiler/Transform/TypeHelper.cs#L180 only collecting base types during the construction of the type hierarchy. This "works" because every interface eventually is an object, as was mentioned in #48, so these casts aren't wrong.
Including interfaces in the type hierarchy complicates things, as the inheritance graph is no longer necessarily a tree any more. This makes looking for common base types more involved, especially if there is diverging paths in the inheritance graphs (which path to take? do we take a path or just resort to Object in those cases?).
We'll have to think about what is best here.
Describe the bug A class's interface implementations are not taken into consideration for tye inference and type conversion insertion.
Example:
IMyDisposable
interface implementsSystem.IDisposable
interface andMyDisposable
class implementsIMyDisposable
interface.OldRod produces the following code: The
castclass
toSystem.IDisposable
is redundant since the parameter which is loaded before it is of typeIMyDisposable
which implementsIDisposable
.If we look at the code before virtualization and then devirtualization we see exactly that.
Similar behavior can be seen where the aforementioned method is used: We see another redundant cast to, this time,
IMyDisposable
. As before this cast is redundant as theMyDisposable
class already implements that interface.If we look at the non-processed code we see the cast is missing:
To Reproduce Devirtualize the sample provided in the zip file below: sample2.zip