search

Washington-University / CiftiLib

C++ Library for reading and writing CIFTI-2 and CIFTI-1 files
BSD 2-Clause "Simplified" License
14 stars 10 forks source link

Support for Qt5 #9

Closed ghisvail closed 8 years ago

ghisvail commented 8 years ago

Does CiftiLib support Qt5? Qt4 support ended last December to the benefit of Qt5 (version 5.6 being supported for 3 years). I suspect Linux distributions will stop providing Qt4 at some point, so supporting Qt5 would future proof the library in that regard.

coalsont commented 8 years ago

I'll have to try it and see, but since it uses so little of QT, I wouldn't be surprised if it just worked.

coalsont commented 8 years ago

commit ed7492a009e1ba6d24e405f98f627ccf9a4ae73e builds against Qt5 on debian testing, but I haven't tried to use it on any files yet. Do you know what target_link_libraries does on a library target? Would it be better to include Qt5's mandated compiler flags a different way?

coalsont commented 8 years ago

The new tests pass under Qt5, with identical output files to Qt4, so I think this is fine.