Washington-University / HCPpipelines

Processing pipelines for the HCP
https://www.humanconnectome.org/
Other
542 stars 272 forks source link

--fix-only option for hcp_fix_multi_run #297

Open demsarjure opened 2 months ago

demsarjure commented 2 months ago

This feature implements a new parameter (--fix-only) for hcp_fix_multi_run. This parameter can be used when to speed up ICAFix optimizations by skipping melodic and proceed with FIX on a previously computed ICA solution.

glasserm commented 2 months ago

For some reason this diff is really hard to interpret. Any idea why it is a sea of red and green even though I assume the changes were pretty minor?

glasserm commented 2 months ago

Also, it looks like there are conflicts that need to be resolved.

coalsont commented 2 months ago

Indentation. In the gear button on the "files changed" page, check "hide whitespace".

Github says no conflicts for squash, but there are some changes from -volume-math/-volume-merge to fslmaths/fslmerge, which I am unsure of the purpose of. If they weren't intentional, something may have been done something with the branch history that could cause a regression (for instance, copying an old version of a file, making edits, and then committing it to the current branch state after a reset).

sivcek commented 2 months ago

I have committed the version with the changes requested:

coalsont commented 2 months ago

The unresolved items as I see it are: