Slack webhook should not be mandatory.

WasiqB / maven-deploy

:recycle: Circle Orb for Maven build and deploy jobs.

https://wasiqb.github.io

Apache License 2.0

2 stars 1 forks source link

Closed WasiqB closed 3 years ago

WasiqB commented 4 years ago

Orb Version

2.0.3

Describe the bug

Currently Slack webhook is mandatory, this should be made optional.

WasiqB commented 4 years ago

Issue still exists.

WasiqB commented 4 years ago

Issue made it mandatory to specify webhook parameter for all the job. This should not be the case.

By default it should check SLACK_WEBHOOK environment variable, if value exists, then use it, else use empty string.