search

WasiqB / multiple-cucumber-html-reporter

Generate beautiful Cucumber HTML reports
https://github.com/WasiqB/multiple-cucumber-html-reporter/blob/main/README.md
MIT License
252 stars 120 forks source link

fix: dark mode in useCDN case #383

Closed sven-seyfert closed 1 month ago

sven-seyfert commented 2 months ago

Hi folks 👋 ,

this should be a fix for #374 . I added a test for the useCDN case and reviewed the report files manually after the creation. Looks good to me, but please do a double check, thanks 🤝 .

I hope this fulfills your contribution guideline. If not, don't hesitate to tell me what I have to change.

Best regards Sven

sven-seyfert commented 2 months ago

Hi 👋 , any thoughts about this PR? Any reaction would be nice, thank you.

WasiqB commented 1 month ago

@Sven-Seyfert , thanks for raising the PR.

Changes look good to me. I will check this tomorrow morning and will merge it if everything is working fine.

WasiqB commented 1 month ago

:rocket: This pull request is included in v3.8.0. See Release 3.8.0 for release notes.