Activate runtime type checks

Wasm-DSL / spectec

Wasm SpecTec specification tools

https://wasm-dsl.github.io/spectec/

Other

27 stars 9 forks source link

Activate runtime type checks #101

Closed rossberg closed 3 months ago

rossberg commented 5 months ago

This PR adds previously missing runtime type checks on the arguments to the instantiate and invoke meta functions. The interpreter cannot currently handle these and will probably need some manual exemptions.

@ShinWonho, can you please look into this? To at least get the spec document correct quickly, perhaps the simplest temporary fix is to somehow just ignore these premises in the interpreter backend.

presenthee commented 3 months ago

@ShinWonho and I made some changes for the temporary fix:

Removed the animate option
Handled rule premises based on suffix matching rule _ok and _const are translated into AssertI. Currently, assertions are not working in the interpreter (thus they are ignored now) and we will revisit this after implementing assertions in the interpreter.

rossberg commented 3 months ago

Thanks @presenthee & @ShinWonho!