search

Wasm-DSL / spectec

Wasm SpecTec specification tools
https://wasm-dsl.github.io/spectec/
Other
25 stars 9 forks source link

CI broken #111

Closed rossberg closed 1 month ago

rossberg commented 1 month ago

Hey folks,

CI has been broken since this commit. The prose renderer incorrectly generates math with a macro invocation for \zbytes after this change. I don’t know where that’s coming from, something somehow bypasses the show hints in the Latex renderer. Could someone please investigate?

Please make sure that CI is always green. Either run make ci locally before pushing, or let github do it by creating a PR. And in case it's broken accidentally (can happen, I certainly have been guilty of that, usually when forgetting to promote test expectations), please fix it right away, even if that might require reverting the change.

jaehyun1ee commented 1 month ago

CI was broken after this commit, where it introduces an AST node InvCallE for inverse function application. The prose renderer did not handle the case properly, which broke the spec CI.

109 handles the problem with InvCallE rendering, will merge on @rossberg's approval :)

rossberg commented 1 month ago

Cool, thanks for the fast fix!

Ah, I was inferring from the CI actions log, where the other commit was the first that showed that specific failure. Perhaps something else masked it on your commit.