WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

update loadable plugin section #106

Closed mhmohona closed 1 year ago

mhmohona commented 1 year ago

Explanation

Update Loadable Plug-in section - expanded explanation and added flowchart for better understanding of the workflow. Also updated as per Yi-Ying's review.

Reopening PR https://github.com/WasmEdge/docs/pull/86 for passing DOC test

Related issue:

What type of PR is this

/kind documentation

Proposed Changes

alabulei1 commented 1 year ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

This pull request aims to update the loadable plugin section of the documentation by providing information on creating and loading plugins in the WasmEdge runtime environment. The key changes include adding explanations on creating loadable plugins, providing example code, and introducing a flowchart to illustrate the plugin loading process.

The potential issues and errors identified include the lack of explicit error handling in the example code for loading plugins and the need for more detailed explanations in the flowchart. It is important to mention the possibility of handling loading failures and improve the flowchart to cover alternative paths and error handling scenarios.

In terms of importance, ensuring proper error handling and clear flowchart explanations are crucial. These improvements will enhance the user experience and understanding of the plugin loading process.

Additionally, it's advisable to check if the flowchart renders correctly in the intended platform before merging the pull request. Furthermore, it is also recommended to review whether the code implementation was modified correctly and adequately, as the changes seem to be related to documentation formatting.

Overall, this pull request brings valuable updates to the loadable plugin section, with potential improvements to error handling and flowchart explanations.

Details

Commit 3a3a4405ef306f7489f4454e77a376571d6841ed

Key changes:

Potential problems:

Commit 503219050511f724638a205ba404ae4be67fec2f

Key Changes:

Potential Problems:

Commit 72d95acf74540e37999121f6adde8643b5120f06

Key Changes:

Potential Problems:

Commit 74791e76162f8b2dd7a4a9eb01cc326bc9a6cee6

Key Changes:

Potential Problems:

adithyaakrishna commented 1 year ago

@alabulei1 CI Workflows need your approval to run. Its a default feature of GH Actions. More Info: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

adithyaakrishna commented 1 year ago

@mhmohona Lint check failing here 👀

mhmohona commented 1 year ago

@adithyaakrishna yes, its the same error I am getting all my PRs. I am unable to fix it. :3

adithyaakrishna commented 1 year ago

@mhmohona There seems to be linting issues in many files which were not changed, I have created a PR #109 to fix the CI and linting issues :)

alabulei1 commented 1 year ago

Hi @mhmohona

Still have one CI that didn't pass. Could you fix again?

mhmohona commented 1 year ago

@alabulei1 I hope cli check will pass now.

adithyaakrishna commented 1 year ago

@alabulei1 The workflows need to be approved manually for it to run 😶

alabulei1 commented 1 year ago

@mhmohona The lint CI passed! But the DCO tests failed. Could you please take a look again? Thanks.