Open hydai opened 1 year ago
Seems like the build check on push and on PR are duplicated.
@adithyaakrishna Can you please take a look? Thanks.
@hydai We have a lint check which uses prettier and eslint for the project
@q82419 I will take a look at that as well 👀
@hydai We are using this Lint workflow
Workflow File: https://github.com/WasmEdge/docs/blob/main/.github/workflows/lint.yml Action: https://github.com/WasmEdge/docs/actions/runs/5261813639/jobs/9520415792?pr=107
Hi @adithyaakrishna I think the current CI is not lint the markdown file. The super-linter is removed in this PR: https://github.com/WasmEdge/docs/pull/109/files#diff-107e910e9f2ebfb9a741fa10b2aa7100cc1fc4f5f3aca2dfe78b905cbd73c0d2L24-L31
However, the eslint doesn't enable the markdown plugin.
Ohh that makes sense, does this workflow auto commits the changes as well?
No idea. We don't do auto commits in the main repo, but it should have if you use the markdown plugin with eslint.
Fixed and Updated in the above PR :)
Bug: The linter is not the same as the original repo https://github.com/WasmEdge/docs/issues/117 The central problem discussed in the issue is that the linter used in the original repository is not the same as the one being used in the current repository. The issue highlights that the current CI is not linting the markdown files, and although the super-linter was removed, the eslint in use does not enable the markdown plugin. The main solution proposed is to update the eslint configuration to enable the markdown plugin. This solution has been acknowledged and addressed in a pull request.
this result is generated by flows.network. Triggered by @WasmEdge
Describe the bug.
The original repo applied markdown-lint with a custom configuration file.
Configuration file
https://github.com/WasmEdge/WasmEdge/blob/master/.github/linters/.markdown-lint.yml
Just save it as
.markdownlint.yaml
.Error log
Describe the steps to reproduce the behavior.
Install markdownlint
Run markdwonlint with given configuration file
Expected behavior.
Let's refine the configuration file or apply markdown-lint to ensure all markdown files follow the same spec.
Screenshots.
No response
Operating Environment
ProductName:macOS ProductVersion:13.4.1 BuildVersion:22F82
Additional Information
No response