WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Remove Prettier #155

Closed juntao closed 1 year ago

juntao commented 1 year ago

Explanation

The prettier command in CI gives extremely unhelpfully error messages. It simply asks me to run prettier without telling me what the actual "style issue" is.

I would NOT permit prettier to make changes to my writing in any way without first knowing what it thinks the problem is.

Plus, we already have lint. I think we should remove prettier.

alabulei1 commented 1 year ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit efad771f35ba2a1868e1ab132b18fab92e028b26

Key changes:

Potential problems:

Overall, it seems the developer has a valid concern regarding the error messages from Prettier, but it is necessary to ensure that the removal of Prettier does not introduce any code style or formatting issues. A discussion with the developer is recommended to clarify the reasons behind the decision and address any potential problems arising from it.

alabulei1 commented 1 year ago

@hydai Do you have any feedback?