Closed juntao closed 1 year ago
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
Key changes:
Potential problems:
Overall, it seems the developer has a valid concern regarding the error messages from Prettier, but it is necessary to ensure that the removal of Prettier does not introduce any code style or formatting issues. A discussion with the developer is recommended to clarify the reasons behind the decision and address any potential problems arising from it.
@hydai Do you have any feedback?
Explanation
The
prettier
command in CI gives extremely unhelpfully error messages. It simply asks me to runprettier
without telling me what the actual "style issue" is.I would NOT permit
prettier
to make changes to my writing in any way without first knowing what it thinks the problem is.Plus, we already have lint. I think we should remove prettier.