WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Add faq page and style guide #193

Closed mhmohona closed 8 months ago

mhmohona commented 11 months ago

Explanation

Added faq page for Wasmedge

Related issue

37

Continuation of PR #198

What type of PR is this

/kind documentation

Proposed Changes

alabulei1 commented 11 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Summary:

The overall summary for the GitHub Pull Request titled "Add faq page and style guide" is as follows:

Potential Issues and Errors:

Key Findings:

Additional Recommendations:

Overall, the patch brings several additions and updates related to the FAQ page, style guide, and troubleshooting guide. Some potential issues and errors should be addressed and reviewed.

Details

Commit 6a5c4a884bae8bb4e4587aca8bbe3bdb44d1e2c3

Key Changes:

Potential Problems:

Commit 3c88c86ea0199f86f7f5b75aea6c451a3162ddd7

Key changes in the patch:

  1. Added a new file STYLE_GUIDE.md that provides a style guide for both documentation and coding.
  2. Updated the faq.md file by making minor changes to the content and adding new links to the WasmEdge documentation and community resources.

Potential problems:

  1. The patch introduces a new file STYLE_GUIDE.md, but it does not specify how this style guide will be used or enforced. It would be beneficial to provide instructions on how contributors should follow this style guide.
  2. The updates to the faq.md file do not seem to address any major issues or improve the existing content significantly. It might be worth discussing with the author if these changes are necessary or if there are other potential improvements.
  3. The links to the WasmEdge documentation and community resources in the faq.md file should be checked to ensure they are correct and up-to-date.

Commit 5a3c420de069c22d85d831f574d709bd9e21628c

Key changes:

Potential problems:

Additional considerations:

Commit a7f3f7bcf4e982f98abc36a7e48c7a4a20c945db

Key Changes:

Potential Problems:

Overall, this patch adds a "Troubleshooting Guide" page and updates the file structure accordingly.

alabulei1 commented 9 months ago

Hi @mhmohona

It seems that #197 includes this PR. Should I merge this PR?

adithyaakrishna commented 9 months ago

@mhmohona I guess this PR is very different from #197. The #197 PR adds testing docs while this PR adds the FAQs. IMHO, it would be good to have the faq page

CC @alabulei1 Could you please review it once again, as I personally feel, having a faq page for the project would be good

mhmohona commented 9 months ago

Hey @adithyaakrishna, thanks for your review! In above comment @alabulei1 meant #198 actually.

alabulei1 commented 8 months ago

Hi @mhmohona

could you please remove your faq page the style guide to https://wasmedge.org/docs/start/overview. We have a separate chapter for getting started. Thanks!