Closed mhmohona closed 8 months ago
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
Summary:
The overall summary for the GitHub Pull Request titled "Add faq page and style guide" is as follows:
Potential Issues and Errors:
STYLE_GUIDE.md
, but it does not specify how this style guide will be used or enforced. Instructions on following the style guide should be provided.faq.md
file do not seem to address any major issues or significantly improve the existing content. Discussions with the author about the necessity of these changes and potential improvements should be considered.faq.md
file should be checked for accuracy and currency.Key Findings:
Additional Recommendations:
Overall, the patch brings several additions and updates related to the FAQ page, style guide, and troubleshooting guide. Some potential issues and errors should be addressed and reviewed.
Key Changes:
docs/develop/getting-started/faq.md
file.i18n/zh/docusaurus-plugin-content-docs/current/develop/getting-started/faq.md
file.Potential Problems:
Key changes in the patch:
STYLE_GUIDE.md
that provides a style guide for both documentation and coding.faq.md
file by making minor changes to the content and adding new links to the WasmEdge documentation and community resources.Potential problems:
STYLE_GUIDE.md
, but it does not specify how this style guide will be used or enforced. It would be beneficial to provide instructions on how contributors should follow this style guide.faq.md
file do not seem to address any major issues or improve the existing content significantly. It might be worth discussing with the author if these changes are necessary or if there are other potential improvements.faq.md
file should be checked to ensure they are correct and up-to-date.Key changes:
Potential problems:
Additional considerations:
Key Changes:
Potential Problems:
Overall, this patch adds a "Troubleshooting Guide" page and updates the file structure accordingly.
Hi @mhmohona
It seems that #197 includes this PR. Should I merge this PR?
@mhmohona I guess this PR is very different from #197. The #197 PR adds testing docs while this PR adds the FAQs. IMHO, it would be good to have the faq page
CC @alabulei1 Could you please review it once again, as I personally feel, having a faq page for the project would be good
Hey @adithyaakrishna, thanks for your review! In above comment @alabulei1 meant #198 actually.
Hi @mhmohona
could you please remove your faq page the style guide to https://wasmedge.org/docs/start/overview. We have a separate chapter for getting started. Thanks!
Explanation
Added faq page for Wasmedge
Related issue
37
Continuation of PR #198
What type of PR is this
/kind documentation
Proposed Changes