[DOCS]Added missing crun instructions

dhruvmehtaaa commented 10 months ago

Explanation

Step 3 of https://wasmedge.org/docs/develop/deploy/podman/#prerequisites: It seems like some instructions are missing.

Build and configure crun with WasmEdge support

Next, configure and build a crun binary with WasmEdge support.

Maybe there should be a git clone, similar to https://wasmedge.org/docs/develop/deploy/oci-runtime/crun/#prerequisites

What type of PR is this

/kind documentation

Proposed Changes

Adds the missing git clone in step 3 of https://wasmedge.org/docs/develop/deploy/podman/#prerequisites Also fixed a typo

alabulei1 commented 10 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 9310218707bf4e1b88410bf3e5bbb822e462600c

Key changes:

Added instructions for building and installing crun with WasmEdge support.
Provided a cautionary note to backup the existing crun before replacing it.

Potential problems:

The instructions assume that the user already has git, autogen.sh, make, and sudo installed. It would be helpful to provide instructions or dependencies for those tools if they are not already installed.
There is a minor typo in the comment: "bakup" should be "backup". It would be good to fix this typo for clarity.

Overall, the changes seem to be straightforward and valuable. The patch provides clear instructions for building and installing crun with WasmEdge support, and includes a warning to backup the existing crun binary before replacing it.

dhruvmehtaaa commented 10 months ago

Hi @juntao Can you please review

juntao commented 10 months ago

Thank you. Can you rebase to remove my commit (the install file) in the PR? Thanks!

dhruvmehtaaa commented 10 months ago

@juntao I have rebased to remove your commit

alabulei1 commented 10 months ago

@juntao I think we can merge this PR?

WasmEdge / docs