WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Add missing command in C plugin guide #201

Closed mhmohona closed 10 months ago

mhmohona commented 10 months ago

Explanation

Add missing command in C plugin guide

Related issue

199

What type of PR is this

/kind bug

Proposed Changes

alabulei1 commented 10 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the patch adds a missing command for building the WasmEdge plugin in the C plugin guide. The key changes include the addition of the gcc command with the appropriate flags and file names. There are no potential problems mentioned in the patch, but it would be helpful to include any known limitations or caveats related to using this command or building the plugin in general. Additionally, it may be beneficial to provide additional context or explanation for why this command is necessary or important. Lastly, it is important to review and ensure the updated command is appropriate and consistent with the surrounding content in the document.

Details

Commit 8e1fb394bdcbacbbdf2e12eb61bc69af8ac91ca9

Key changes:

Potential problems:

Overall, the patch adds a missing command in the C plugin guide to build the shared library using the command line. It appears to be a straightforward and correct addition.

Commit 1527aeb83b3253f7870efff1c96589d339619c17

Key changes:

Potential problems: