Closed mhmohona closed 10 months ago
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
Overall, the patch adds a missing command for building the WasmEdge plugin in the C plugin guide. The key changes include the addition of the gcc
command with the appropriate flags and file names. There are no potential problems mentioned in the patch, but it would be helpful to include any known limitations or caveats related to using this command or building the plugin in general. Additionally, it may be beneficial to provide additional context or explanation for why this command is necessary or important. Lastly, it is important to review and ensure the updated command is appropriate and consistent with the surrounding content in the document.
Key changes:
testplugin.c
file into a shared library named libwasmedgePluginTest.so
.Potential problems:
Overall, the patch adds a missing command in the C plugin guide to build the shared library using the command line. It appears to be a straightforward and correct addition.
Key changes:
gcc -std=c11 -DWASMEDGE_PLUGIN -shared -o libwasmedgePluginTest.so testplugin.c
.Potential problems:
Explanation
Add missing command in C plugin guide
Related issue
199
What type of PR is this
/kind bug
Proposed Changes