search

WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Update the section about running a simple WASI app with runwasi #214

Closed CaptainVincent closed 7 months ago

CaptainVincent commented 7 months ago

Explanation

Complete the full steps with the latest runwasi.

Related issue

Twitter

What type of PR is this

documentation

Proposed Changes

Missing content, as well as outdated steps.

alabulei1 commented 7 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 24746cf41070fc926b3e3b4c8914c07fd20675c9

Key Changes:

  1. Updated the section about running a simple WASI app with runwasi in the containerd.md file in the docs/develop/deploy/cri-runtime/ directory.
  2. Removed the "Work in Progress" message and possibly outdated information related to installing WasmEdge.
  3. Adjusted the steps for downloading the runwasi project.
  4. Updated the build and installation steps for wasmedge-containerd-shim.
  5. Removed duplicate and redundant content.
  6. Updated the command for running a simple WASI app with runwasi.

Potential Problems:

  1. In the updated steps, there are a few commands that involve using sudo for installing dependencies. This should be used cautiously as it grants elevated privileges and may not be necessary in all environments.
  2. Some content has been removed or modified, so it's essential to ensure that any critical information wasn't unintentionally omitted or altered.
  3. The patch appears to have restructured and improved the clarity of the document. However, as a reviewer, it's crucial to verify if all necessary steps for running a simple WASI app with runwasi are still accurately described.
  4. The changes seem to be significant, so reviewing the context and making sure the revisions align with the overall documentation structure is important.