WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Fix the boost dependency when building from source. #230

Closed q82419 closed 4 months ago

alabulei1 commented 4 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 35f0ab3c93755dd48bbd9434e281a0034f8d5415

Key changes:

  1. The patch removes the libboost-all-dev dependency from the build instructions in linux.md, riscv64.md, and image.md files.
  2. The patch updates the build instructions to reflect that the boost dependency is not needed after WasmEdge 0.13.0.
  3. The patch includes adjustments in both English and Chinese documentation files.

Potential problems:

  1. The patch may cause issues for users trying to build from source who rely on the libboost-all-dev library.
  2. It might be beneficial to explicitly mention in the updated instructions why the boost dependency was removed and if there are any alternative dependencies or changes in the codebase that make boost unnecessary.