search

WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Mark the rustls plug-in as deprecated. #231

Closed q82419 closed 2 months ago

alabulei1 commented 4 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 0a5d9bbd29da18e9d306b885f9572316c9864406

Key Changes:

  1. The GitHub Patch marks the rustls plug-in as deprecated after version 0.14.0.
  2. It provides a note explaining the deprecation and the replacement of rustls with reqwest.

Potential Problems:

  1. The patch changes multiple files, indicating a wide-reaching impact of deprecating the rustls plug-in.
  2. Users who rely on the rustls plug-in may need guidance on transitioning to the recommended reqwest alternative.
  3. The deprecation note could be more detailed, providing guidance on migration steps or alternatives for affected users.
  4. Ensuring that documentation and examples are updated to reflect the deprecation of the rustls plug-in and the adoption of reqwest.
  5. It might be necessary to update any tutorials or guides that reference the rustls plug-in to avoid confusion for users.

Overall, the deprecation of the rustls plug-in in favor of reqwest seems like a significant change that will require proper communication and documentation updates for impacted users.

alabulei1 commented 3 months ago

Hi @juntao ,

Could you please help check out this PR?

hydai commented 2 months ago

@q82419 Please fix the conflicts

hydai commented 2 months ago

@q82419 Please fix the conflict.