search

WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

docs: update youki build instructions #232

Closed hegerdes closed 3 months ago

hegerdes commented 3 months ago

Explanation

Youki changed its build system form make to just.

Both are not really needed to build youki with wasm since you can just run the build script. Updated the instructions and added missing apt packages for wasm like libzstd-dev, curl and git

Related issue

Does not exist yet

What type of PR is this

/kind documentation

Proposed Changes

Update the build instructions

alabulei1 commented 3 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 301d66a5feceedf188ef4a61096ecf7ed60cbbfe

Key Changes:

  1. Updated build instructions for youki to reflect a change from using make to executing a build script.
  2. Added missing apt packages for wasm support, such as libzstd-dev, curl, and git.
  3. Included a command to install the Rust toolchain if not already installed.

Potential Problems:

  1. The instruction to run curl https://sh.rustup.rs -sSf | sudo sh -s -- -y to install the Rust toolchain with sudo privileges may pose security risks. It is generally recommended to avoid running scripts directly from the internet with sudo.
  2. The patch should include information on the potential impacts or risks involved in changing the build system from make to executing a build script for users who are familiar with the previous build process.
  3. The patch doesn't specify the purpose of the changes or any additional context, which could be helpful for reviewers to understand the rationale behind the modifications.
hydai commented 3 months ago

Hi @hegerdes Could you please sign your commits with DCO? Ref: https://www.secondstate.io/articles/dco/

hegerdes commented 3 months ago

Thought of trying out GitHub UI for this small change - gives the source branch a meaningless name and does not sign-off.

Lernend my lesson, local git form now on only with my known config. Is now fixed.

hydai commented 3 months ago

Thanks