Closed PeterD1524 closed 2 months ago
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.
wasi_nn.md
file. This redundancy should be addressed to avoid confusion and maintain document coherence.Considering the need to address the duplication issue of the "Appendix" section and the necessity to ensure the integrity of the documentation by providing context for section removal, the patch requires further refinement before merging into the codebase. Additionally, the correction of the typo and the valuable additions to the Appendix enhance the overall documentation quality, indicating positive progress towards improving user experience and clarity.
Key Changes:
wasi_nn.md
file under the docs/contribute/source/plugin/
directory.Appendix
section below the build instructions for the WasmEdge with WASI-NN Neural Speed Backend.WASMEDGE_PLUGIN_PATH
environment variable and lists pre-built ggml plugins on different platforms.Potential Problems:
Key Changes:
wasi_nn.md
documentation file.Potential Problems:
Recommendation:
Considering the simplicity and correctness of the changes, this patch seems ready for merging into the codebase.
I fixed some docs:
Build WasmEdge with WASI-NN Neural Speed Backend
part in the wrong place.Apple Silicon Model
parts. One is in the MacOS section afterIntel Model
part and the other is in the Linux section afterGeneral Linux without any acceleration framework
part. I removed the one in the Linux section afterGeneral Linux without any acceleration framework
part.