WasmEdge / docs

https://wasmedge.org/docs/
Apache License 2.0
17 stars 57 forks source link

Add a twitter card for WasmEdge/Docs #76

Closed alabulei1 closed 1 year ago

alabulei1 commented 1 year ago

Is your feature request related to a problem? Please describe.

WasmEdge's docs don't have a preview card.

image

Describe the solution you'd like.

Follow the instruction from docusarus to add one: https://docusaurus.io/docs/next/api/themes/configuration#meta-image

Describe alternatives you've considered

No response

Additional context.

No response

alabulei1 commented 1 year ago

We can use the stacked WasmEdge logo as the preview image.

eshaanagarwal commented 1 year ago

Great ! I would like to take this up. i will send the pull request in some time.

eshaanagarwal commented 1 year ago

We can use the stacked WasmEdge logo as the preview image.

can you please share the link to this logo?

kokamkarsahil commented 1 year ago

can you please share the link to this logo?

You can use the assets located here: https://github.com/WasmEdge/docs/tree/main/static/img

ashutosh-rath02 commented 1 year ago

@eshaanagarwal are you working on this?

adithyaakrishna commented 1 year ago

@Lucif3r-in Wanna take this up?

ashutosh-rath02 commented 1 year ago

@Lucif3r-in Wanna take this up?

Sure @adithyaakrishna

adithyaakrishna commented 1 year ago

@Lucif3r-in I dont have the permissions to assign you to this, but you can work on it and send a PR which I will be glad to review :)

ashutosh-rath02 commented 1 year ago

@adithyaakrishna Can you suggest where to make the changes? It used to be in _document.ts but I can't find it.

adithyaakrishna commented 1 year ago

@Lucif3r-in You would need to make the change in this file, https://github.com/WasmEdge/docs/blob/main/docusaurus.config.js and the required change and how to do it can be found here, https://docusaurus.io/docs/next/api/themes/configuration#meta-image

ashutosh-rath02 commented 1 year ago

image @adithyaakrishna I am getting this error when I try to commit my changes. Can you tell me where I am going wrong? P.s- I have tried npm run lint:style

adithyaakrishna commented 1 year ago

@Lucif3r-in I will send a fix for this, for now you can commit using a flag --no-verify which will make your command as git commit -m "fix: add meta image for twitter card

ashutosh-rath02 commented 1 year ago

Done @adithyaakrishna