search

WasmEdge / wasmedge-rust-sdk

Embed WasmEdge functions in a Rust host app
Apache License 2.0
30 stars 15 forks source link

Update archives SHA and bump crates versions #113

Closed jprendes closed 4 months ago

jprendes commented 4 months ago

Fix #108: Update the SHA values. Fix #107: Update the readme and inline docs version table.

juntao commented 4 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 4c4c56148cfccd4154bb3ca503c11004f9e4524e

Key Changes:

  1. Updated the version of the main crate (wasmedge-sdk) in Cargo.toml from 0.14.0 to 0.14.1.
  2. Bumped the version of the wasmedge-sys crate in both Cargo.toml and crates/wasmedge-sys/Cargo.toml from 0.19.0 to 0.19.2.
  3. Updated the WASMEDGE_RELEASE_VERSION constant in crates/wasmedge-sys/build.rs from "0.13.5" to "0.14.0".
  4. Updated the SHA values for different platforms in crates/wasmedge-sys/build.rs.

Potential Problems:

  1. The changes seem to be straightforward version updates and SHA modifications, so there might not be any major problems with the patch itself.
  2. Make sure that the updated versions are compatible with any dependencies or other crates in the project.
  3. Ensure that the SHA values in crates/wasmedge-sys/build.rs are correct and correspond to the updated archives.

Overall, the patch appears to be updating versions and corresponding SHA values, which seem fine at a high level. However, thorough testing after applying the changes is recommended to ensure the integrity of the project.

jprendes commented 4 months ago

@L-jasmine @hydai PTAL 🙏

L-jasmine commented 4 months ago

LGTM Thank you so much for your pr