WasmEdge / wasmedge-rust-sdk

Embed WasmEdge functions in a Rust host app
Apache License 2.0
30 stars 15 forks source link

[Chore] Update build script #86

Closed apepkuss closed 1 year ago

apepkuss commented 1 year ago

In this PR, the sha256sums are updated to WasmEdge v0.13.5.

juntao commented 1 year ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

The pull request titled "[Chore] Update build script" contains two key changes. Firstly, the constant "WASMEDGE_RELEASE_VERSION" in the build script for the "wasmedge-sys" crate is being updated from "0.13.4" to "0.13.5". Secondly, the sha256sum values in the "REMOTE_ARCHIVES" constant are being updated.

Upon review, no potential problems or issues have been found with these changes. They appear to be routine updates to the build script and do not introduce any obvious problems.

In conclusion, this pull request seems to be a simple and straightforward update to the build script with no apparent issues.

Details

Commit 07b7e8ad0fcc6f9dda32ba98685bbbe32f7921c3

Key changes:

Potential problems:

Commit 1cabbb9af03b1183bfb393b836dd3c942442403f

Key Changes:

Potential Problems:

Overall, the key changes in this patch involve updating the sha256sum values in the build script. These changes don't introduce any obvious problems.

apepkuss commented 1 year ago

@hydai Could you please help review this PR? Thanks a lot!

apepkuss commented 1 year ago

@hydai Thanks for the review!