WasmEdge / wasmedge-rust-sdk

Embed WasmEdge functions in a Rust host app
Apache License 2.0
29 stars 15 forks source link

Relax the version of `wat` dep #90

Closed apepkuss closed 10 months ago

apepkuss commented 10 months ago

In this PR, relax the version of wat dep to fix #88. In addition, the test cases affected by the change also get updated.

juntao commented 10 months ago

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the Pull Request includes a variety of changes. Here are the most important findings:

  1. Relaxing the version of the wat dependency may introduce compatibility issues with the rest of the codebase or other dependencies. The rationale for this change should be provided to ensure it is intentional and necessary.

  2. The changes to the test code include new implementations and modifications in multiple files. It is important to ensure that the changes don't introduce potential bugs or performance issues. Additionally, the changes in some test files are marked with #[ignore], suggesting that the tests need updates. These updates should be made before merging the changes.

  3. The version bump of the wasmedge-sys crate and the update of the wasmedge-sdk version don't appear to have any potential problems.

Considering all the individual summaries, the most important finding is the potential compatibility issues that may arise from relaxing the version of the wat dependency. It is important to address this concern and provide a clear rationale for the change. Additionally, the changes in the test code need further review to ensure they don't introduce bugs or performance issues and that the tests are appropriately updated.

Details

Commit 0c0632321494f2eee1d745b0cbfd11dc1c9c2dd7

Key changes:

Potential problems:

Additional notes:

Commit eed350a0fc3872512c2427ee157b9c22ad875f78

Key changes:

Potential problems:

Overall, the changes seem to be focused on improving the test code for the Rust SDK. However, without additional context or information, it is difficult to assess the impact and potential problems of these changes in the larger codebase.

Commit fd2abf93bd054ef1201419cc28e05844d4f09184

Summary of key changes:

Potential problems:

Commit 1cb5a1da951acbd7100de75e498a2868b44006bb

Key changes:

Potential problems:

Overall, this patch appears to be a straightforward update to the wasmedge-sys crate version.

Commit 01acb32aa97ba9772466a887edb1f682ed145308

Key changes:

Potential problems:

Commit 2a177acc54b29c3f25dc961a4af1b9def1da20a9

Key changes:

Potential problems:

apepkuss commented 10 months ago

@hydai Could you please help review this PR? Thanks a lot!

apepkuss commented 10 months ago

@hydai Thanks for the review!