Wassimulator / CactusViewer

A small single file image viewer written in C/C++.
BSD 2-Clause "Simplified" License
203 stars 15 forks source link

Crash opening file from command line or `Open with...` #25

Closed azmr closed 6 months ago

azmr commented 1 year ago

CactusViewer crashes when started in a way that will immediately open an image.

The crash appears to be in atidxx64.dll

Some observations:

Caveat:

tek256 commented 1 year ago

Able to reproduce by running:

.\CactusViewer.exe OfficeFloorplan.png

image

azmr commented 1 year ago

Interestingly this isn't quite the same as the crash I'm seeing. Mine is a read access violation from at 0x0008

I got the same assert hit as this when trying CactusViewer.exe --help (and similar), but Wassim said that just wasn't handled yet.

On Fri, 24 Nov 2023 at 22:34, Devon @.***> wrote:

Able to reproduce by running:

.\CactusViewer.exe OfficeFloorplan.png

image.png (view on web) https://github.com/Wassimulator/CactusViewer/assets/3059752/72757010-e440-462c-a6d4-794aab6038b3

— Reply to this email directly, view it on GitHub https://github.com/Wassimulator/CactusViewer/issues/25#issuecomment-1826117829, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKRKDGOW7TXPQZF5XPDVQ3YGEOI5AVCNFSM6AAAAAA7X4LOECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGEYTOOBSHE . You are receiving this because you authored the thread.Message ID: @.***>

Wassimulator commented 6 months ago

should be fixed with #35 Please report any issues if there are any missed edgecases! yeah I need to support --help at some point indeed, but there isn't much to do in the cmdline but open a file.