Wassup789 / YouTube-Notifications

A Chrome extension created to notify users when a new video is uploaded on YouTube
MIT License
25 stars 7 forks source link

The settings window looks silly in french #5

Closed Pizzacus closed 8 years ago

Pizzacus commented 8 years ago

(The volume section)

I might fix it myself, I just wanted to let you know because I have no idea about what could be done at the moment

Pizzacus commented 8 years ago

Maybe if we had the volume slider under the notification switch, it would leave much more place for the test button

Wassup789 commented 8 years ago

That would work but the switch would have too much white space.

Pizzacus commented 8 years ago

We could fill this white-space by making the test button bigger, but maybe it'll look weird, because it would be too big

(Note: On this image, I know the button isn't bigger, I just want to be sure that I'm clear on what I'm suggesting)

Pizzacus commented 8 years ago

It could also just be a little bigger and be centred vertically and horizontally in the space left

Wassup789 commented 8 years ago

The white-space I'm concerned about is the notification on/off switch.

Wassup789 commented 8 years ago

2016-08-16_16-14-37 Changed the letter-spacing to -0.5px, removed padding and the volume slider width to 90px. I think this works best. Looking into the import subscriptions button row now.

Pizzacus commented 8 years ago

Maybe yes, I think would be the best, as far as I can tell

Pizzacus commented 8 years ago

I think this issue is the only issue of this kind (presentation problems when using the french version)

Wassup789 commented 8 years ago

Alright, that's great. Thank you.