search

WatWowMap / ReactMap

Pokemon GO Map frontend built with React
MIT License
123 stars 62 forks source link

[Feature Request]: Exclude rocket grunt toggle & exclude rocket leader toggle #1021

Closed Gattaca1 closed 2 months ago

Gattaca1 commented 2 months ago

Adds 2 toggles to further filter Rocket Pokemon: Exclude Rocket Leaders & Exclude Rocket Grunts.

It should be noted that I've only tested this with a limited data setup (actually just 2 pokestops, one with character ID 16, and one with character ID 41), so it could use a test with a larger set of data. I don't have a scanner set up so I'm unable to do this

Boby360 commented 2 months ago

I tested the code when it was on the main branch with success.

It would be amazing to have an equivalent of the Quest Conditions advanced filter, although I understand if it would be out of scope. https://github.com/WatWowMap/ReactMap/blob/develop/src/components/filters/QuestConditions.jsx

Gattaca1 commented 2 months ago

Ready for review now!

Gattaca1 commented 2 months ago

Updated the branch back to develop

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.33.0-develop.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: