Update GeoURI to drop a pin when opened with Google Maps

WatWowMap / ReactMap

Pokemon GO Map frontend built with React

MIT License

123 stars 62 forks source link

Update GeoURI to drop a pin when opened with Google Maps #990

Closed frett closed 5 months ago

frett commented 5 months ago

Wikipedia lists an unofficial extension using the q parameter to have Google Maps show a pin from a GeoURI. See: https://en.wikipedia.org/wiki/Geo_URI_scheme#Unofficial_extensions

I tested this on Android Google Maps and opening the link directly through the Tesla app.

I also tested the url pattern: geo:0,0?q={x},{y}, but opted to go with the committed pattern to account for external maps that may not recognize the q parameter

TurtIeSocks commented 5 months ago

Thanks for the PR but can you change the target to develop? I'll sync them up in the very near future as I don't have much planned for develop currently.

frett commented 5 months ago

give me a second to rebase and remove the other changes that are from master :)

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.32.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: