Bring back `scan_zone_choose` text

WatWowMap / ReactMap

Pokemon GO Map frontend built with React

MIT License

123 stars 62 forks source link

Closed kamieniarz closed 5 months ago

kamieniarz commented 5 months ago

scan_zone_choose text was removed with https://github.com/WatWowMap/ReactMap/pull/810 So here's my (proly ulgy and wrong) PR to bring it back. Works for me 🤷‍♂️

TurtIeSocks commented 5 months ago

Thanks for the contribution! A little overkill though, you could revert all these commits and just do something like:

secondary={t(mode === 'scanZone' ? 'scan_zone_choose' : 'scan_next_choose')}

kamieniarz commented 5 months ago

Obviously that works 😅 Thanks!

TurtIeSocks commented 5 months ago

Obviously that works 😅 Thanks!

Great! Just fix the prettier issue yarn prettier:fix and I'll get this merged.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.32.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: