WaterByWind / edgeos-bl-mgmt

Automated updating of EdgeOS firewall network-group to be used as source address blacklist
MIT License
196 stars 40 forks source link

Silence sed warning #12

Closed mklxd closed 5 years ago

mklxd commented 5 years ago

To silence the following error message from sed, apply the patch below: sed: character class syntax is [[:space:]], not [:space:]

Patch:

diff --git a/updBlackList.sh b/updBlackList.sh
index d04caca..246b9d0 100755
--- a/updBlackList.sh
+++ b/updBlackList.sh
@@ -475,7 +475,7 @@ doProcess4()
     cat ${flBlockList} | \
         sed -e '/^[;#]/d' \
             -e '/ERROR/d' \
-            -e '/[:\::]/d' \
+            -e '/[\:\::]/d' \
             -e 's/ .*//g' \
             -e 's#//.*##g' \
             -e 's/[^0-9,.,/]*//g' \
WaterByWind commented 5 years ago

I do not receive this error. Are you running this on your edgerouter or elsewhere? On edgeos 'sed' is actually the busybox implementation.

mklxd commented 5 years ago

Yes. I get this error running on ER4 under 2.0 beta-3

WaterByWind commented 5 years ago

Ah - You probably mean 2.0.0-alpha.3. FYI that is actually not a beta and is actually a still in-development alpha that is currently still undergoing significant changes. I do not see the error on alpha-2, for instance.

Once that version moves into a beta (it has not yet) I will be testing there but until then it is still far too early to try to chase as the platform is still in too great of a state of change.

I'll keep this open to track until then.

mklxd commented 5 years ago

You’re right, it’s alpha3. UBNT upgraded to Debian stretch on this version.

On Sep 14, 2018, at 2:09 PM, WaterByWind notifications@github.com wrote:

Ah - You probably mean 2.0.0-alpha.3. FYI that is actually not a beta and is actually a still in-development alpha that is currently still undergoing significant changes. I do not see the error on alpha-2, for instance.

Once that version moves into a beta (it has not yet) I will be testing there but until then it is still far too early to try to chase as the platform is still in too great of a state of change.

I'll keep this open to track until then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

WaterByWind commented 5 years ago

I've pushed this minor update (finally). It has been working on both 1.x and 2.x releases for me and it just took me finding the 30 seconds to publish it. . .