WaterByWind / edgeos-bl-mgmt

Automated updating of EdgeOS firewall network-group to be used as source address blacklist
MIT License
196 stars 40 forks source link

Update process stops when trying to add a wrong IP syntax #5

Open wolterink opened 7 years ago

wolterink commented 7 years ago

One of the sources contained a wrong IP (195.78.82.0/234 China)

which returned a error ipset v6.23: Error in line 32227: Syntax error: '234' is out of range 0-32

This stops the whole process of updating. Could there be a filter that would ignore such wrong entries?

WaterByWind commented 7 years ago

Hmmm. I could probably work something in but would need to think about it.

Did this happen just once or does it happen repeatedly or even occasionally?

wolterink commented 7 years ago

It’s an occasional occurrence. I only seen it once where they made an error in their IP list. They do corrected it a few day later and the code worked again. But I thought I would be a nice addition to your code to make it a bit more error (made by others) proof.

On 24 Jul 2017, at 16:06, WaterByWind notifications@github.com wrote:

Hmmm. I could probably work something in but would need to think about it.

Did this happen just once or does it happen repeatedly or even occasionally?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WaterByWind/edgeos-bl-mgmt/issues/5#issuecomment-317452807, or mute the thread https://github.com/notifications/unsubscribe-auth/AGDCeX9E1TIpCZxcAlEOQLk0-Fjs_wg7ks5sRLLfgaJpZM4OWnV7.