WaterFutures EPyT-Flow issues

WaterFutures / EPyT-Flow

A high-level interface designed for the easy generation of hydraulic and water quality scenario data.

https://epyt-flow.readthedocs.io/en/stable

MIT License

18 stars 4 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

A suggestion: I think it would be nice to add a page at the beginning of the in-depth tutorial summarizing the functionalities epyt-flow offers. This could include a complete list of the uncertainties, events, faults, and controls you allow users to model, and ideally would include time series or spatial plots to better visualize these things (e.g., abrupt and incipient leaks, sensor override attacks, different uncertainty distributions, etc). Having all of these cases in one single page could provide users with a clear overview of what the package offers

#22 andreArtelt opened 2 weeks ago
1
Events -> Sensor faults: currently epyt-flow can model only one kind of fault affecting any sensor, right? Just curious - in the future, will you consider allowing multiple faults to affect sensors?

#21 andreArtelt opened 2 weeks ago
1
Scenarios -> Basics: what sort of "potential exceptions that might occur during the process of setting up and running the simulation" might a user encounter?

#20 andreArtelt opened 2 weeks ago
1
Abrupt Leakage Example: not a big deal at all, but would it be possible to standardize the y-axis ticks so it is easier to interpret?

#19 andreArtelt opened 2 weeks ago
1
I recommend adding legends to all plots with multiple lines so it is clear what each line represents. And also checking the x and y axis labels and ticks (e.g. in Pump State Events Example top plot, does y axis value = 2.0 means the pump is off and 3.0 mean the pump is on? In the bottom plot, are you plotting tank water volume? I think it is straightforward to interpret the plots if you are a WDS expert but it might be useful to have more clear plots for newer users! :-) )

#18 andreArtelt closed 2 weeks ago
2
Event Detection: would it be possible to elaborate a little more on the results and the plot? Is the algorithm able to successfully detect one event but not all three?

#17 andreArtelt closed 2 weeks ago
2
What is the default sensor placement for each network/scenario?

#16 andreArtelt closed 2 weeks ago
3
Events -> Actuator events: actuator events are analogous to EPANET time-based controls, correct? What takes precedence if you have both an actuator event and a control acting on an element (e.g., a pump)?

#15 andreArtelt closed 2 weeks ago
2
How would you recommend new users learn to use the package? Would you suggest they first go through the in-depth tutorial then recreate all the examples? Since epyt-flow offer so many functions, I think it would be great to include suggestions for how to get started! Or at least add a link to the in-depth tutorial on the landing page since it seems like a very important guide to the package functionalities

#14 andreArtelt closed 2 weeks ago
2
Events -> Leakages: how are leaks modeled in epyt-flow? I see leaks are assigned to pipes, unlike in EPANET, where leaks are modeled by assigning emitter coefficients to junctions.

#13 andreArtelt closed 2 weeks ago
2
Modeling of water distribution networks -> Topology: in the definition of a pump, how do you define "segment?" I would add that pumps add hydraulic head to the system or something to that extent

#12 andreArtelt closed 2 weeks ago
2
Scenarios -> Basics: what happens if you don't close the scenario?

#11 andreArtelt closed 2 weeks ago
2
JOSS Review

#10 kbonney closed 6 days ago
14
JOSS Review

#9 meghnathomas opened 1 month ago
16
geodataframes objects

#8 jorgelcq closed 4 months ago
3
ScadaDataXlsxExport - export functions - If I want to see also the raw data? not only sensor readings?

#7 Mariosmsk closed 8 months ago
3
Sometimes I have the error below - self.__find_temporary_file()

#6 Mariosmsk closed 6 months ago
5
WaterDistributionNetworkScenarioSimulator change to `Simulator` or `ScenarioSimulator` or `FlowSimulator`

#5 Mariosmsk closed 8 months ago
1
Improve how we retrieve sensor readings over the entire simulation

#4 Mariosmsk closed 8 months ago
3
Add new specific functions for each sensor type

#3 Mariosmsk closed 8 months ago
1
Create action - `draft-pdf.yml`

#2 Mariosmsk closed 7 months ago
0
Create actions for build - `build_tests.yml`

#1 Mariosmsk closed 7 months ago
0