WaterlooRobotics / mobilerobotics

Matlab and Robot code for MTE 544: Autonomous Mobile Robotics at the University of Waterloo
66 stars 38 forks source link

I10 unscented kalman filter #41

Closed cbchau closed 7 years ago

cbchau commented 8 years ago

The new unscented kalman filter has refactored code into separate functions. In addition, the filter parameters have been tuned and the example made more similar to the assignment.

yshiyi commented 8 years ago

fig1 Please consider commenting on what each of state represents for and what the two inputs are.

yshiyi commented 8 years ago

fig2 I think "Q" defines the measurement disturbance. Maybe rephrase the comment.

yshiyi commented 8 years ago

fig3 Instead of listing the definitions of each input variable, how about put the definition and variable together as follows: A: state matrix; B: input matrix; ... etc.

yshiyi commented 8 years ago

Overall, this is an excellent work. I have looked through your codes several times and don't think I have anything to suggest. Everything looks clean, neat and consistent.

neginlashkari commented 8 years ago

You have functionalized the code. Unfortunately, the effects of changes you have made to the previous codes was not clear to me. I think it is better to put more comments for your changes to show how did you improve the example, how you improved and tuned the filter. You can also define a parameter to show this new code is more optimized.

cbchau commented 8 years ago
  1. Put comment on state and input to be position and velocity
  2. Renamed the "Q" variable to motion disturbance
  3. Updated all the functions to have more clear descriptions of variables in the comments
  4. Example was changed to be more consistent with other examples 4a. Input was separated out of the position matrix 'A' into a 'B' matrix 4b. dt was taken out of the initial velocity at the beginning and applied during the position calculation in both EKF and UKF ex. x2 = A_x1 + B_v*dt
  5. Filter was tuned such that the changing initial conditions,noise and variations in disturbances do not affect convergence