Closed cbchau closed 7 years ago
Please consider commenting on what each of state represents for and what the two inputs are.
I think "Q" defines the measurement disturbance. Maybe rephrase the comment.
Instead of listing the definitions of each input variable, how about put the definition and variable together as follows: A: state matrix; B: input matrix; ... etc.
Overall, this is an excellent work. I have looked through your codes several times and don't think I have anything to suggest. Everything looks clean, neat and consistent.
You have functionalized the code. Unfortunately, the effects of changes you have made to the previous codes was not clear to me. I think it is better to put more comments for your changes to show how did you improve the example, how you improved and tuned the filter. You can also define a parameter to show this new code is more optimized.
The new unscented kalman filter has refactored code into separate functions. In addition, the filter parameters have been tuned and the example made more similar to the assignment.