some spell/skill usages give error output

[GoogleCodeExporter]

n/t

Original issue reported on code.google.com by tric...@gmail.com on 13 Jun 2011 at 2:27

[GoogleCodeExporter]

I think this is db related.  looks like there some new monsters in there.  
lacking the db info on them, it probably just bugs.

Original comment by tric...@gmail.com on 13 Jun 2011 at 3:16

[GoogleCodeExporter]

in the logs when you try to summon

Jun 13, 2011 11:42:43 AM l1j.server.server.clientpackets.C_UseSkill <init>
SEVERE: 
java.lang.ArrayIndexOutOfBoundsException: 8
    at l1j.server.server.clientpackets.ClientBasePacket.readH(Unknown Source)
    at l1j.server.server.clientpackets.C_UseSkill.<init>(Unknown Source)
    at l1j.server.server.PacketHandler.handlePacket(Unknown Source)
    at l1j.server.server.ClientThread$HcPacket.run(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:662)

Original comment by tric...@gmail.com on 13 Jun 2011 at 3:43

[GoogleCodeExporter]

fixed in r451 with darkwolfs help.

Still getting that error in the log though.  I think its due to a change in 
L1SkillUse where summoncost was changed to 8, since the logging output has an 8 
I'm assuming thats the prob.  I dont want to just change it back to 6, it 
probably should be 8, but a catch needs to be put someplace or we need to find 
where/why 8 is no good.

not marking as fixed yet, but it is, other than the error

Original comment by tric...@gmail.com on 13 Jun 2011 at 5:09

[GoogleCodeExporter]

changing priority to low since its fixed, just outputting an error still

Original comment by tric...@gmail.com on 13 Jun 2011 at 5:20

• Added labels: Priority-Low
• Removed labels: Priority-Critical

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I noticed today the above error output wasn't unique to summon monster.  I'm 
still seeing it a lot on linret.

changed the summary and raised to medium priority.  Not sure if its having any 
in game effect

Original comment by tric...@gmail.com on 15 Jun 2011 at 9:44

• Changed title: some spell/skill usages give error output
• Added labels: Priority-Medium
• Removed labels: Priority-Low

[GoogleCodeExporter]

today i didnt noticed it anymore very odd

Original comment by Nuijen...@gmail.com on 17 Jun 2011 at 9:48

[GoogleCodeExporter]

not entirely sure about this, but it looks like the error output we're seeing 
may just be because before, we always had the line commented out that would 
even provide that error.  It could be a normally caught exception and we just 
never saw it before because we chose to comment that out at some point.

If so the mage summon spell may have nothing to do with this error, and this 
error in general can be ignored.

See C_UseSkill.java

                _log.log(Level.SEVERE, "", e);

before the merge that line was commented out, and has probably always been the 
case.  So this is either an ancient bug we ignored on purpose because it didn't 
affect gameplay and we just made it stop bitching about it (and it may have 
been accounted for elsewhere in code), an ancient bug we never noticed BECAUSE 
we commented that out and never noticed, or still something new lol

Original comment by tric...@gmail.com on 19 Jun 2011 at 7:03

[GoogleCodeExporter]

I'm pretty sure the mage summon bug isn't a bug, and this error output is 
"normal" as far as it goes.

I'm moving it to low priority, I may go back and see if I can find the real 
cause of the output and make it more elegant and verify it isn't something to 
worry over, but for now all seems fine even with the output

Original comment by tric...@gmail.com on 19 Jun 2011 at 7:07

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

may be fixed in r601 but needs testing to confirm there's no bad side affects

Original comment by tric...@gmail.com on 28 Jun 2011 at 3:56

[GoogleCodeExporter]

after my fix i had it only with 1 darkelf spell today other class spells i 
didnt had the error. darkelf only

Original comment by Nuijen...@gmail.com on 28 Jun 2011 at 5:09

[GoogleCodeExporter]

done

Original comment by Nuijen...@gmail.com on 25 Jul 2011 at 5:16

• Changed state: Done